unbridled-41 commented on PR #5895: URL: https://github.com/apache/rocketmq-dashboard/pull/5895#issuecomment-6091132018
### Description corrected: the reason did reach the screen, the contradiction is the defect Reviewing this PR's premise I overstated one point, and the description now says it precisely: `web/src/api/client.ts` already toasts the server's business message (`message.error(getBusinessError(error.response?.data))` before rethrowing), so in a browser the operator *does* see "Audit log export exceeds the maximum of 10000 records; narrow the filters". What the page adds on top is the wrong advice — `导出审计日志失败，请稍后重试` — as the last toast on screen. The fix is unchanged and still correct: the page should carry the reason itself and must not tell the operator to retry a request that deterministically fails. The Problem/Evidence and impact sections of the description were updated accordingly; the code, tests and evidence in the PR are unaffected (the test drives the page with a rejected axios-shaped error, which is exactly the path the page now handles). No new commit: this is a description-only correction. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
