The GitHub Actions job "CI" on 
rocketmq-dashboard.git/fix/query-history-snapshot has failed.
Run started by GitHub user Frun1na (triggered by Frun1na).

Head commit for run:
37bf0a95da8ae67e094ee26a0de40e72e490da31 / Apulupie 
<[email protected]>
fix(message): skip a history row whose snapshot cannot be written

Review follow-up: report the unreadable snapshot as 500, which this repository
uses for an unreadable persisted value (502 is reserved for upstream RPC
unavailability), and close the matching hole on the write side.

buildResultSnapshot returned null when serialization failed, and the caller
then stored resultCount = result.size() next to that null snapshot, which
reads back as "nothing stored": the row listed N results and served none. It
now throws, and MessageService's existing history-write guard logs the failure
and skips the row; the query result itself is returned unchanged.

Report URL: 
https://github.com/apache/rocketmq-dashboard/actions/runs/38018604102

With regards,
GitHub Actions via GitBox

Reply via email to