f1amingo opened a new pull request, #1396: URL: https://github.com/apache/rocketmq-clients/pull/1396
### Summary `npm run lint` reports 42 errors across `nodejs/src` and `nodejs/test`. The Node.js CI job (`nodejs_build.yml`) only runs `npm i && npm run init && npm run build && npm pack` and never lints, so these violations accumulated unnoticed and break any lint-based gate / local `npm run ci`. This PR clears all of them with lint-only changes — no runtime behavior is affected. ### Changes - Auto-fixable style: parenthesize ambiguous conditional arrow bodies (`no-confusing-arrow`), normalize `array-bracket-spacing`. - `// eslint-disable-next-line @typescript-eslint/no-unused-vars` for intentionally-unused positional params (`InflightRequestCountInterceptor`, `IpNameResolver`, `IpNameResolver.test`). - Empty mock methods → `() => undefined` (`no-empty-function`) in `ProcessQueue.test` and `hook.test`. - Test-only `require()` wrapped in an `eslint-disable @typescript-eslint/no-var-requires` block in `hook.test` (kept as `require` to preserve the `any` typing the mocks rely on). ### How Did You Test This Change? - `npm run lint`: 0 errors (was 42). - `npm run build`: passes. - `npx egg-bin test` on all touched files: green (hook 12, IpNameResolver 10, fixes 17, Semaphore 4, PublishingLoadBalancer 3, ProcessQueue). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
