lizhimins commented on PR #5317: URL: https://github.com/apache/rocketmq-dashboard/pull/5317#issuecomment-6094437906
The fix itself is correct: `RocketMQMessageProvider.java:253` is the only message-query catch block in the file that does not already grade `TOPIC_NOT_EXIST` as business-empty (`:449`, `:664`, `:713` and `RocketMQDLQProvider.java:538` all do), and your red/green evidence checks out line for line. We are closing it as a duplicate of #5287, which changes the same line for the same issue (#5286) and was opened 11.7 hours earlier by the issue reporter; #5287 is itself a re-submission of #4918. Two things worth carrying over to whichever patch lands, since neither PR has them: your description says the unique-key path already grades `TOPIC_NOT_EXIST`, but `queryMessageByUniqueKey` at `:294` grades only `NO_MESSAGE, QUERY_NOT_FOUND` and reaches the same 502 at `:300` — both of its branches end in `MQAdminImpl.queryMessage`, so a route-less topic fails there identically. Grading it in the same pass would close the family. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
