lizhimins commented on PR #5770: URL: https://github.com/apache/rocketmq-dashboard/pull/5770#issuecomment-6094440611
The ordering contract argument is valid — `RealClusterProvider` already sorts its table walk (`RealClusterProvider.java:133`) and this provider did not — but please soften the rationale: a `HashMap` iterates deterministically for an identical key set, so the list does not actually reshuffle between two requests of the same cluster; the real win is consistency with the sibling provider and predictable output. Two things before merge: (1) the same family is still unfixed one level down — `buildBrokerList` (line 219) walks `entry.getValue()`, a deserialized `HashSet`, so brokers inside each cluster remain hash-ordered while `RealClusterProvider.java:146` sorts them by name; please sort those too (or say why not); (2) rename the test to end with `Test` per repo convention. We would like to merge this together with #5771 so the cluster list and the dashboard overview agree. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
