Loyal-Young opened a new pull request, #6053: URL: https://github.com/apache/rocketmq-dashboard/pull/6053
### Which Issue(s) This PR Fixes - Fixes #6050 ### Brief Description Resolve successful conversation deletions against the conversation active when deletion completes. A pending delete previously captured the old active ID: navigating elsewhere could be undone, while navigating into the conversation being deleted could leave its deleted transcript active. Keep this decision in the mounted modal shell. Closing only the history panel still ends a successfully deleted active conversation; leaving the AI page stops old deletion callbacks from navigating. The panel also skips its own state updates and refresh after unmount. ### How Did You Test This Change? - Before the fix: 3 failures and 22 passes in ConversationListModal tests. - After the fix: all 25 pass, including deferred deletes followed by navigation away, navigation into the deleted conversation, closing history, and unmounting the shell. - Existing tests cover failed and partial deletions, selection, and empty-page recovery. - ESLint on both changed files, full app TypeScript check (`--noEmit --composite false --incremental false`), and `git diff --check`: passed. ### Checklist - [x] One coherent change; Conventional Commit title. - [x] Regression tests added; new test names end in Test. - [x] No new UI strings or public API contracts. - [ ] Backend architecture tests not rerun locally (frontend-only change). ### CI baseline Tested on 29fe48abc. Its [frontend job](https://github.com/apache/rocketmq-dashboard/actions/runs/38023023425/job/114127943196) already fails the artifact license gate after build/tests; its [backend build](https://github.com/apache/rocketmq-dashboard/actions/runs/38023023425/job/114127943241) already fails the binary license gate. PR CI still needs to run independently. ### AI assistance AI assistance was used to trace the deletion lifecycle, implement the completion callback and author the deferred-response tests. The diff and test results were reviewed in this contribution session. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
