Loyal-Young opened a new pull request, #6058:
URL: https://github.com/apache/rocketmq-dashboard/pull/6058

   ### Which Issue(s) This PR Fixes
   
   - Fixes #6055
   
   ### Brief Description
   
   Invalidate Queue Browser requests when the message page unmounts. Existing 
sequence checks handled topic and instance changes, but a rejected queue load 
or message pull could still publish a global error toast after the user left 
the page.
   
   The effect cleanup advances the existing request sequence. Requests owned by 
the current page retain their error reporting.
   
   ### How Did You Test This Change?
   
   - Before the fix: 2 failures and 9 passes in QueueBrowser tests.
   - After the fix: all 11 tests pass. Deferred load/pull failures after 
unmount produce no toast; failures on the mounted page still report an error.
   - The new tests run in StrictMode and verify that a newly mounted browser 
can load queues and pull a message successfully.
   - ESLint: no errors (one existing fast-refresh warning in the component 
file).
   - Full app TypeScript check (`--noEmit --composite false --incremental 
false`) and `git diff --check`: passed.
   
   ### Checklist
   
   - [x] One coherent change; Conventional Commit title.
   - [x] Regression tests added; new test names end in Test.
   - [x] No new UI strings or public API contracts.
   - [ ] Backend architecture tests not rerun locally (frontend-only change).
   
   ### CI baseline
   
   Tested on 29fe48abc. Its [frontend 
job](https://github.com/apache/rocketmq-dashboard/actions/runs/38023023425/job/114127943196)
 already fails the artifact license gate after build/tests; its [backend 
build](https://github.com/apache/rocketmq-dashboard/actions/runs/38023023425/job/114127943241)
 already fails the binary license gate. PR CI still needs to run independently.
   
   ### AI assistance
   
   AI assistance was used to trace request lifetime, implement the cleanup, and 
write deferred-response tests. The diff and test results were reviewed in this 
contribution session.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to