The GitHub Actions job "CI" on 
rocketmq-dashboard.git/fix/aliyun-incomplete-list-page has failed.
Run started by GitHub user Frun1na (triggered by Frun1na).

Head commit for run:
857ef5c2b6903f4bf73dc25a3f6296910d41226c / Apulupie 
<[email protected]>
fix(aliyun): reject incomplete topic and consumer group pages

The Aliyun topic and consumer group scans ended on a short page without 
consulting TotalCount: their
shared hasFetchedAll compared the rows requested (page * PAGE_SIZE) with the 
total instead of the
rows the response carried, so a short page that still left offset + returned 
below a known
non-negative TotalCount closed the loop silently and Studio rendered a 
truncated topic or consumer
group inventory as if it were complete. The same defect was fixed on the 
Tencent side in 34b03320
(fix(tencent): reject incomplete resource pages) for three scans; this brings 
listTopics and
listConsumerGroups to the same shape - requireCompletePage throws 502 when a 
short page contradicts
TotalCount, hasFetchedAll counts returned rows, and a missing or negative 
TotalCount keeps the
previous short-page termination so a genuinely empty catalog still resolves to 
an empty list.

Verified with `mvn -B -ntp test -Dtest=AliyunInstanceProviderTest`: 43 tests 
green, 0 checkstyle
violations, including the existing short-page-without-total test.

Report URL: 
https://github.com/apache/rocketmq-dashboard/actions/runs/38036276253

With regards,
GitHub Actions via GitBox

Reply via email to