The GitHub Actions job "CI" on 
rocketmq-dashboard.git/fix/topic-remark-column-bound has failed.
Run started by GitHub user Frun1na (triggered by Frun1na).

Head commit for run:
02df1dc362cc2d3824fd27b1e2aa27927c6f6dd8 / Apulupie 
<[email protected]>
fix(topic): bound the topic and group text the registration columns cannot store

fix(topic): bound the topic and group text the registration columns cannot store

A topic remark, a topic name or a consumer-group name longer than 255 
characters reached the
persistence layer, which rejected the write with a 
DataIntegrityViolationException; the request ended
as a 500 from the generic handler instead of the validation error the 
surrounding paths return. The
instance write path already bounds its free text to the widths db/schema.sql 
declares (#4713).

`MetadataService.requireTopic` now bounds the topic name and remark, and 
`saveConsumerGroup` bounds
the group name, to the 255-code-point width of `rmq_instance_topic.name`, 
`rmq_instance_topic.remark`
and `rmq_instance_group.name`. The bound is counted in code points, the unit 
MySQL counts a varchar
in, so a name that fits the column is not rejected for using two UTF-16 units 
per character.

`MetadataServiceTest`: 62 tests green, 0 checkstyle violations. The two 
rejection tests fail on the
unfixed code ("Expecting code to raise a throwable"), and a topic remark of 
exactly 255 characters is
still accepted.

Report URL: 
https://github.com/apache/rocketmq-dashboard/actions/runs/38037074021

With regards,
GitHub Actions via GitBox

Reply via email to