The GitHub Actions job "CI" on 
rocketmq-dashboard.git/fix/credential-tostring-redaction has failed.
Run started by GitHub user Frun1na (triggered by Frun1na).

Head commit for run:
3135fb9a486658ddff4f8e678a1759b1177e7e3d / Apulupie 
<[email protected]>
fix(persistence): keep stored credentials out of the credential types' toString

fix(persistence): keep stored credentials out of the credential types' toString

A Lombok `@Data` class prints every field, secret columns included, so one log 
line, exception
message or diagnostic dump that renders one of these objects writes the 
credential to disk. The
repository already excludes the secrets of `RmqSettings` (LLM API key), 
`RmqStudioUser` (password
hash), `RmqK8sCertificate` (private key), `K8sCertVO`, 
`CreateCloudCredentialDTO`,
`UpsertPlainAccessConfigDTO`, `DataSourceTestDTO`, 
`MetricsDataSourceQueryRequest`,
`GeneralSettingsVO` / `GeneralSettingsUpdateDTO` and `LoginDTO` / 
`ResetPasswordDTO`; the k8s
redaction fix (#4555) named the remaining credential-bearing types as a 
follow-up.

`RmqCloudCredential` and `RmqAclUser` now exclude `accessKey` / `secretKey`, 
`RmqDataSource`
excludes `json` (the serialized `MetricsDataSourceConfig` carries `password` / 
`bearerToken`), and
`PlainAccessConfigVO` excludes `accessKey` / `secretKey`, matching the 
annotation the write DTO for
the same model already carries.

`CredentialToStringRedactionTest`: 4 tests green, 0 checkstyle violations; each 
assertion keeps an
identifier field in the representation and fails on the unfixed code.

Report URL: 
https://github.com/apache/rocketmq-dashboard/actions/runs/38038154535

With regards,
GitHub Actions via GitBox

Reply via email to