Frun1na opened a new pull request, #6144:
URL: https://github.com/apache/rocketmq-dashboard/pull/6144
### Which Issue(s) This PR Fixes
- Fixes #6139
### Brief Description
`LiteTopicSessionVO.popProgress` is declared and serialized but never
assigned: no provider writes
`LiteTopicSession.popProgress` (or its `PopConsumeProgress` shape), so the
session drawer's
"Pop 进度" panel could only ever render from a fixture and
`rmq.litetopic.session` published a
component the server never computes. Four tests kept the dead path looking
covered because each one
built the value by hand.
Following #5600, which dropped the fabricated NameServer "Connections"
column instead of filling it
with a guess, the counter is removed together with everything built on it:
- the session drawer's Pop-progress panel, its TypeScript field and the
`liteTopic.popProgress`
translation entry;
- `LiteTopicSessionVO.popProgress`, `LiteTopicSession.popProgress` and the
nested
`PopConsumeProgress` shape;
- `LiteTopicSessionOutput.popProgress` and its
`tool-catalog/tools/litetopic.yaml` property, with
`catalog_gen.go` regenerated.
User-visible change: the LiteTopic session drawer no longer reserves a
Pop-progress section that never
had data. Nothing that was ever reported is lost — the value was `null` for
every session.
### How Did You Test This Change?
```
cd server && mvn -B -ntp test -DforkCount=1
-Dsurefire.failIfNoSpecifiedTests=false \
-Dtest='LiteTopicControllerTest,LiteTopicServiceTest,LiteTopicSessionToolHandlerTest,ToolOutputSchemaContractTest,RocketMQLiteTopicProviderTest'
Tests run: 49, Failures: 0, Errors: 0, Skipped: 0
BUILD SUCCESS (checkstyle: 0 violations)
make -C rmqctl catalog-verify ✓
npx eslint <the five changed web files> ✓
npx prettier --check <the same files> ✓
npx tsc -b ✓
npx vitest run src/pages/studio/__tests__/LiteTopic.test.tsx --maxWorkers=1
--fileParallelism=false
Tests 16 passed (12.5s)
```
`ToolOutputSchemaContractTest` validates the `LiteTopicSessionOutput` sample
against the YAML schema
(`additionalProperties: false`), so it fails if the field comes back without
its catalog property.
The new case fails when the panel is restored with the fixture value it used
to accept:
```
$ npx vitest run src/pages/studio/__tests__/LiteTopic.test.tsx
--maxWorkers=1 --fileParallelism=false
Tests 1 failed | 15 passed (16)
does not offer a POP progress panel the API never fills
```
### Checklist
- [x] One coherent change; unrelated modifications are not bundled in
- [x] Commit subject follows Conventional Commits (`feat:` / `fix:` /
`refactor:` / `chore:` / `docs:` / `perf:`)
- [x] Tests added or updated for non-trivial changes, test methods named
`...Test`
- [ ] New UI text has both Chinese and English entries under `web/src/i18n/`
- [ ] Architecture constraints stay green (`mvn test` runs the ArchUnit
checks)
- [ ] New source files carry the ASF license header
- [ ] Documentation touched where behaviour changed (README / `docs/` /
in-app help)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
