The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git/fix/consume-message-directly-null-buffer has failed. Run started by GitHub user zjncs (triggered by zjncs).
Head commit for run: fb70a24c44698e5ab76c2f7396afc462e0786b25 / zjncs <[email protected]> [ISSUE #D9] Guard consumeMessageDirectly against unresolvable msgId consumeMessageDirectly dereferences the SelectMappedBufferResult returned by selectOneMessageByOffset without a null check, so a msgId whose offset no longer maps to a stored message (expired/deleted commitlog, or a msgId belonging to another broker) makes the broker throw a raw NullPointerException into the remoting layer instead of answering the admin request. The empty catch of UnknownHostException is worse: when the msgId cannot be decoded at all, the request is forwarded to the consumer with a null body, and the consumer fails with an unrelated decode error. Respond SYSTEM_ERROR with an explicit remark in both cases, and never invoke the consumer without a message body. Signed-off-by: zjncs <[email protected]> Report URL: https://github.com/apache/rocketmq/actions/runs/34466105642 With regards, GitHub Actions via GitBox
