zmuxuny commented on PR #5363: URL: https://github.com/apache/rocketmq-dashboard/pull/5363#issuecomment-6096855710
Thanks for the review. Addressed the three points in 142f251157de3feb8fd4743cc7f0e5f6b48e2507. 1. Checked the actual JDK 21 inheritance: FilterInputStream.skip delegates to the underlying stream, while readAllBytes, both readNBytes variants and transferTo already inherit InputStream implementations that invoke our overridden reads. BoundedStdout now extends InputStream directly, so skip also uses budgeted reads; close still delegates. Tests cover all five APIs, exact-budget EOF and mixed skip/read consumption. The two skip regressions fail before the fix. 2. Reused the package-visible CliAgentProvider.OutputLimitException and a single gateway-error formatter for both buffered and streaming paths. 3. Renamed the hosted-frame case to describe the aggregate stdout limit it actually asserts, and narrowed both READMEs accordingly. No parser heap-size assertion is claimed. Final focused matrix: 305/305 passed, Checkstyle zero violations, diff check passed, independent review completed. The published tree matches the tested tree. Current-head CI: Frontend Docker and Go passed; Frontend Build is still running. Backend Build failed at the binary-license gate. Backend Tests ran 3442 tests with one H2 ConcurrentModificationException in ResourceOwnershipGuardTest.migrationConcurrentStartupIsIdempotentTest; the same test passed in the concurrent #5255 run. A job-specific retry to investigate this suspected unrelated concurrency flake was blocked by the integration's GitHub permissions. Overall CI is not green: https://github.com/apache/rocketmq-dashboard/actions/runs/38046758033 . Ready for re-review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
