tju-yxq opened a new pull request, #6151:
URL: https://github.com/apache/rocketmq-dashboard/pull/6151
> Resubmission of #5162 — the original PR and its linked issue were closed
by the repo's 7-day stale bot while awaiting review, not because the change was
rejected. The fix is rebased unchanged onto the current `rocketmq-studio` head
(5e4c39b0) and the linked issue is still reproducible on trunk.
### Which Issue(s) This PR Fixes
- Fixes #3297
### Brief Description
Re-submits the previously reviewed change (supersedes #4483, which was
auto-closed by the stale bot after 7 days without activity) rebased onto
current `master` at `0228dad5`. The per-message trace request cache is bounded
(`BoundedPromiseCache`, 32 entries with in-flight deduplication and
oldest-entry eviction) so exploring a large message list can no longer grow the
cache without limit. During the rebase the hardcoded error fallback strings
from the original change were dropped in favour of the localized
`t('messagePage.queryFailed')` / `t('messagePage.traceLoadFailed')` messages
that #4633 introduced on `master`.
### How Did You Test This Change?
Run on the rebased branch (`d39c647c`):
```
cd web && npm test -- MessagePage boundedPromiseCache --run
Test Files 3 passed (3)
Tests 37 passed (37)
cd web && npm run lint
0 errors (11 pre-existing warnings in unrelated files)
```
The run covers the new `boundedPromiseCache` unit tests plus the MessagePage
suites, including the trace-drawing and late-response regression tests that
current `master` carries.
### Checklist
- [x] One coherent change; unrelated modifications are not bundled in
- [x] Commit subject follows Conventional Commits
- [x] Tests added or updated for non-trivial changes, test methods named
`...Test`
- [x] New UI text has both Chinese and English entries under `web/src/i18n/`
- [x] Architecture constraints stay green (`mvn test` runs the ArchUnit
checks)
- [x] New source files carry the ASF license header
- [ ] Documentation touched where behaviour changed (README / `docs/` /
in-app help)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
