The GitHub Actions job "CI" on 
rocketmq-dashboard.git/fix/brokercluster-tps-sort-unknown has failed.
Run started by GitHub user Frun1na (triggered by Frun1na).

Head commit for run:
adbefa114e457e409e34f35a310b8f2c69070ee9 / Apulupie 
<[email protected]>
fix(cluster): keep an unmeasured TPS out of the lowest-sort position

Both TPS columns on the broker/cluster page sorted a broker whose runtime stats 
are unavailable as the
lowest value: the record keeps `tpsIn`/`tpsOut` as `null` and the cells render 
`-`, but the sorter used
`(a.tpsIn ?? -1) - (b.tpsIn ?? -1)`, so those rows led an ascending sort as if 
their TPS were the smallest
measured one.

The sorter now uses a direction-aware key: an unavailable value sorts after 
every measured one in both
directions, matching what `onlineInstancesSortValue` and `lagSortValue` do for 
their columns. No user-facing
copy changes.

Report URL: 
https://github.com/apache/rocketmq-dashboard/actions/runs/38043788672

With regards,
GitHub Actions via GitBox

Reply via email to