The GitHub Actions job "License checker" on 
rocketmq.git/fix/processor-null-body-guard has failed.
Run started by GitHub user zjncs (triggered by zjncs).

Head commit for run:
4327967e78226ea5942e3f5c7df12806138783bc / zjncs <[email protected]>
[D20] Guard broker processors against requests whose body decodes to null

RemotingSerializable.decode returns null when the request carries no
body, and several broker processors dereference the decoded object
right away, so a request without a body (a bare probe, or a client bug)
turns into a NullPointerException in the broker instead of a clean
error response:

- ClientManageProcessor.heartBeat
- QueryAssignmentProcessor.queryAssignment
- QueryAssignmentProcessor.setMessageRequestMode
- AdminBrokerProcessor.updateAndCreateTopicList
- AdminBrokerProcessor.updateAndCreateSubscriptionGroupConfigList
- AdminBrokerProcessor.lockBatchMQ / unlockBatchMQ
- AdminBrokerProcessor.notifyBrokerRoleChanged
- AdminBrokerProcessor.createUser / updateUser

Newer code already follows the null-check convention after decode
(LiteSubscriptionCtlProcessor, AckMessageProcessor,
updateAndCreateSubscriptionGroupConfig, checkClientConfig), so this
brings the remaining sites in line: each guarded site now answers
SYSTEM_ERROR with a remark naming the missing body.

Signed-off-by: zjncs <[email protected]>

Report URL: https://github.com/apache/rocketmq/actions/runs/34478547670

With regards,
GitHub Actions via GitBox

Reply via email to