lizhimins commented on PR #5760: URL: https://github.com/apache/rocketmq-dashboard/pull/5760#issuecomment-6094439564
The fix itself is right — `successTerminalProjected` and `stopRacedSuccess` are strictly complementary (set together in `recordTerminal`), so moving the check ahead of `abortReason` is exactly "an abort only wins when it preceded the success frame", and the existing `aStopDuringTheRunShouldWriteStoppedEvenWhenTheProviderReportsSuccess` case still holds. Two mechanical cleanups before merge: (1) the new `properties()` helper duplicates the `AiConversationProperties` construction already in `setUp()` — please extract one shared helper; (2) the ~35-line anonymous `AgentProvider` duplicates `AiRunTestSupport.StubAgentProvider`. We see why the stub is not enough today (`beforeStream` fires before the script, not between frames) — the preferred shape is to add a per-event hook to `StubAgentProvider` and reuse it; if you keep the anonymous provider, add a comment saying so. Also please soften the "reshuffles between requests" wording if you touch the description. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
