The GitHub Actions job "CI" on rocketmq-dashboard.git/fix/dlq-pagination-clamp 
has failed.
Run started by GitHub user Frun1na (triggered by Frun1na).

Head commit for run:
ed8542876e086b84c0389cb50538a6715c65b1d6 / Apulupie 
<[email protected]>
fix(dlq): clamp both dead-letter lists back to the last valid page

The repository has a documented clamp for server-paginated lists: when a page 
query answers with no rows but
a non-zero total and the page is past the first, re-query the last valid page 
instead of rendering a
permanently empty table (see the comment on the alerts page). Both dead-letter 
lists were missing it:

- the group list: resending drains dead-letter groups and the server reaps 
empty ones, so a user sitting on
  the last page keeps seeing an empty group table with the old total while the 
search box is the only way out.
- the message drawer: resending every message of the current page empties it, 
and the reload kept the drawer
  on that page, showing an empty list until the user paged away.

The group list now re-queries the final page like the other pages do, and the 
drawer re-loads the final page
in place (its load is imperative, so it re-runs rather than waiting for a 
state-driven effect). No new
user-facing text.

Report URL: 
https://github.com/apache/rocketmq-dashboard/actions/runs/38038782069

With regards,
GitHub Actions via GitBox

Reply via email to