zmuxuny opened a new pull request, #6182: URL: https://github.com/apache/rocketmq-dashboard/pull/6182
### Which Issue(s) This PR Fixes Fixes #6176 ### Brief Description Compare high-risk consumer settings edits against the last successfully saved settings, rather than the snapshot originally loaded by the detail dialog. Previously, enabling consumption and then disabling it in the same dialog skipped the stop-consumption confirmation; reverting a saved ordered-consumption change likewise skipped confirmation. Only a successful save advances the baseline. The save captures the settings request identity, so validation, a pending confirmation, or a late response from a closed dialog cannot affect a different group. Closing the dialog clears its baseline and submitting state. ### Verification - Before the fix, the new enable-then-disable regression failed on `5e4c39b053c35a5598cc79ff331b8a54e649d7b1`: expected one confirmation, observed none. - Regression coverage: enable then disable and cancel; reverse a saved ordered-consumption change; retain the accepted baseline after a failed save; ignore a closed group's pending save when another group is opened. - `npm test -- src/pages/instance/__tests__/ConsumerPage.test.tsx src/pages/instance/__tests__/ConsumerPageDiagnosticsRace.test.tsx --maxWorkers=1`: 52 tests passed. - `npm run lint`: 0 errors, 10 existing warnings. - `npm run build`: passed, including the production artifact license check. - `git diff --check`: passed. The complete frontend test suite and backend tests were not run for this frontend-only change. AI assistance was used to investigate and implement the fix; the failure was reproduced before changing the source, the code was independently reviewed, and the checks above were run on the final files. GitHub CI is pending. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
