iloveeyjafjalla opened a new pull request, #6189: URL: https://github.com/apache/rocketmq-dashboard/pull/6189
### Which Issue(s) This PR Fixes A dedicated bug report will be linked immediately after this PR is opened. Related observations: #5882 reports the same Windows build blocker; #5346 records the two Windows license-test portability problems outside its scope. ### Brief Description On a Windows `core.autocrlf=true` checkout, `npm run build` rejects the verified toggle-selection LICENSE because Git converts its LF bytes to CRLF. The base LICENSE/NOTICE delimiter also misses CRLF, and the packaging test generates invalid JavaScript imports from Windows paths. Canonicalize CRLF in the tracked legal text before splitting or verifying/distributing it, while retaining the pinned upstream SHA and the raw code/artifact checks. Quote portable paths in the existing Vite fixture. Two regressions cover identical legal outputs/component records for LF and CRLF, and rejection of genuinely changed license text or dependency code. ### How Did You Test This Change? Windows 11 (10.0.26200), Git 2.49.0.windows.1, Node 24.15.0, npm 11.12.1; baseline `5e4c39b053c35a5598cc79ff331b8a54e649d7b1`. Dependencies were installed with `npm ci` in the isolated checkout and shared with the baseline worktree through a local directory junction. No broker, database, deployment, or Linux run is claimed. - Clean baseline: `npm run build` exits 1 at the toggle-selection verification after transforming 8,098 modules; existing `npm run license:test` passes 2/5. - Same expanded license suite against old production code: 3/7 passed, 4 failed, including the new CRLF acceptance regression. The tamper-rejection regression already passed before the fix. - After the fix with CRLF LICENSE/NOTICE/fallback files: `npm run license:test` passes 7/7; `npm run build` succeeds and the final gate reports 133 actual components, 140 license files. - `npm run lint`: exit 0, no errors, 10 warnings in untouched files. - `node --check` on both changed scripts and targeted ESLint unused-variable/control-flow checks: exit 0. `git diff --check`: clean. - Full frontend test result will be recorded before publication. AI assistance: OpenAI Codex was used for investigation, implementation, and running the checks above. A separate automated reviewer examined the actual diff and regression evidence; this is not a claim of human or maintainer review. ### Checklist - [x] One coherent change; unrelated modifications are not bundled in - [x] Conventional Commit subject - [x] Regression tests added, names end in `Test` - [x] New UI translations: N/A, no UI text changed - [ ] Backend architecture tests: not run, no Java files changed - [x] ASF source headers retained; no new source file - [x] Documentation: N/A, restores the existing frontend build/license contract -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
