zmuxuny opened a new pull request, #6198:
URL: https://github.com/apache/rocketmq-dashboard/pull/6198

   ### Which Issue(s) This PR Fixes
   
   Fixes #6192
   
   ### Brief Description
   
   Refresh the current credential/data-source query after a deletion completes, 
instead of calling the list loader captured when deletion began. A delete 
completion now requests a refresh through the current query effect. The latest 
response's total drives page clamping, including an empty result set returning 
to page 1.
   
   Previously, changing the search while deletion was pending let its 
continuation issue the old search and overwrite the newer query. The 
credentials tab then remained behind its query-mismatch loading guard; the 
data-source tab displayed the old query's rows. Deleting the last row of an old 
page could also move the operator away from a page they had since selected.
   
   This PR covers deletion completion only. It does not change create/update 
modal lifecycles or introduce a duplicate-submission guard.
   
   ### Verification
   
   - Before the fix, 8 new regressions failed on 
`5e4c39b053c35a5598cc79ff331b8a54e649d7b1`; 5 control cases passed.
   - Both tabs cover search changes during deletion, navigation before deletion 
finishes, normal last-page recovery, zero-total recovery, failed deletion 
preserving the current query, and no follow-up list request after unmount. A 
credential regression also covers a refresh completed during the search 
debounce window, with its old response arriving after the new search result.
   - The existing request-sequence check runs before page clamping, so an 
obsolete response cannot move the current page.
   - `npm test -- src/pages/settings/__tests__/CloudCredentialTab.test.tsx 
src/pages/settings/__tests__/DataSourceTab.test.tsx --maxWorkers=1`: 40 passed.
   - `npm run lint`: 0 errors, 10 existing warnings.
   - `npm run build`: passed, including the production artifact license check.
   - `git diff --check`: passed.
   
   The complete frontend suite and backend tests were not run for this 
frontend-only change. AI assistance was used; the failures were reproduced 
before changing production code, and a separate reviewer reviewed the diff and 
independently verified the regressions.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to