zmuxuny opened a new pull request, #6196:
URL: https://github.com/apache/rocketmq-dashboard/pull/6196

   ## Summary
   
   Fixes #6186. Follow-up to X-LightYear's unmerged #4995 / #4994, revalidated 
against current trunk and extended to broker discovery.
   
   Apply the configured physical-cluster restriction of a default cluster alias 
consistently to two provider read paths:
   
   - Reject out-of-scope cluster detail with the provider's existing 
null/absent result, without reading that cluster's runtime statistics.
   - Limit broker discovery to the selected cluster's membership. Explicit 
out-of-scope brokers return 404; unavailable membership metadata returns 503 
instead of falling back to all brokers.
   - Preserve global detail lookup and registered instances with null 
configured scope.
   
   This is a selected-cluster consistency fix, not a claim about ACL security 
isolation. It does not change global cluster discovery or the 
configuration-update repository fallback in ClusterService.
   
   ## Validation
   
   - Red: 24 core tests against unchanged production code, 5 new failures and 
19 passes. Foreign detail/broker reads and absent membership fell through to 
the shared topology.
   - Green: 207 focused tests across RocketMQClusterProviderTest, 
ClusterServiceTest, ClusterControllerTest, BrokerConfigDiffServiceTest, 
AclServiceTest, BrokerListToolHandlerTest, BrokerDescribeToolHandlerTest, 
RuntimeAdminClientResolverTest; zero failures/errors and zero Checkstyle 
violations.
   - Nine new regression instances cover member/non-member lookups, 
empty/missing/null membership, registered null-scope compatibility, and global 
detail compatibility.
   
   Validation compiled the changed production/test classes with javac against 
previously built trunk dependencies, then ran `mvn checkstyle:check 
surefire:test` with those eight test selectors. No live broker or full 
MySQL-backed integration suite was used.
   
   AI assistance was used for implementation and regression validation. An 
independent reviewer approved the change and independently passed 27 focused 
tests.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to