zmuxuny opened a new pull request, #6199: URL: https://github.com/apache/rocketmq-dashboard/pull/6199
## Summary Fixes #6194. Credit to yyqdbngt's unmerged #4674 for identifying the missing cloud-group failure scope; this follow-up revalidates and narrows the observable impact on current trunk. Preserve a known consumer group's clusterId on the three cloud progress-failure samples. Without it, a cluster-scoped native Rule Test filters out the UNAVAILABLE samples and returns an empty list, even though the group identity is known. Tencent migrated groups expose this identity through ClusterIdV4. Whole-instance failure markers remain unscoped with empty labels. Null group scopes and successful measurements are unchanged. Current reconciliation already protects existing numeric alerts through unavailable group labels, and business lag rules do not support the UNAVAILABLE operator. This PR fixes diagnostic visibility/sample identity; it does not claim to fix false RESOLVED events or missing unavailable-condition alerts. ## Validation - Red against unchanged production code: 5 tests, 3 failures for cluster-scoped total lag / maximum queue lag / topic backlog diagnostics; 2 compatibility tests passed. - The regression exercises actual Tencent provider mapping, cloud collector, and native Rule Test logic with mocked SDK responses, repositories, registry and client factory. No cloud account was contacted. - Green: 98 focused tests passed with zero Checkstyle violations. Changed production/test classes were compiled with javac against previously built trunk dependencies, followed by `mvn checkstyle:check surefire:test` for TencentCloudLagFailureScopeTest, CloudRocketMqBusinessMetricsCollectorTest, TencentInstanceProviderTest, NativeAlertRuleTestServiceTest and NativeAlertProcessorTest. - Independent review: new provider-chain tests plus Rule Test tests, 12/12 passed. - Compatibility with independent #6184: clean temporary merge, recompiled the merged collector and both regression classes, 49 relevant tests passed. Both PRs remain independently based on trunk. Seven new regression instances cover diagnostic visibility, other-cluster exclusion, null scope, healthy measurement, and whole-instance failure. No full MySQL-backed integration suite was run. AI assistance was used for implementation and regression validation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
