RockteMQ-AI commented on PR #11355: URL: https://github.com/apache/rocketmq/pull/11355#issuecomment-6104649842
Thanks for the detailed explanations, @messere1. **1. Clock domain consistency** — Agreed. Keeping `currentTimeMillis` aligned with the subscription expiry clock domain is the right call. Mixing `nanoTime` would introduce unnecessary complexity for a TTL window where NTP slew is negligible. **2. Test timing margin** — The 10x margin (200ms vs 20ms TTL) is a solid improvement. The reasoning about `Thread.sleep` never undershooting is correct, and the additional clock-step tolerance is a nice bonus at minimal test-runtime cost. **Clock injection** — Fair to defer. The existing pattern of real-clock aging is consistent across the lite test suite, and injecting a clock for a non-blocking nit would be over-engineering at this stage. The changes in 01e5b7d09 address the observations well. No further action needed from my side. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
