The GitHub Actions job "Run Integration Tests" on 
rocketmq.git/fix/receive-message-null-client-settings has failed.
Run started by GitHub user zjncs (triggered by zjncs).

Head commit for run:
f45cf33972c2d96d5bb284b8a27e74a2b4186bee / zjncs <[email protected]>
fix(proxy): return UNRECOGNIZED_CLIENT_TYPE when client settings is null in 
receiveMessage

A gRPC client that calls ReceiveMessage before any settings were cached
(or after its settings were cleaned up) made getClientSettings return
null, and the following settings.getClientType() threw a
NullPointerException which the catch block turned into an opaque
INTERNAL_SERVER_ERROR response.

ClientActivity.heartbeat already guards this case with
UNRECOGNIZED_CLIENT_TYPE; apply the same guard in receiveMessage so the
client gets a meaningful code.

Report URL: https://github.com/apache/rocketmq/actions/runs/34573319130

With regards,
GitHub Actions via GitBox

Reply via email to