Wang1rrr opened a new pull request, #6276:
URL: https://github.com/apache/rocketmq-dashboard/pull/6276

   ### Which Issue(s) This PR Fixes
   
   Fixes #4042.
   
   ### Brief Description
   
   The existing empty-account case also disables ACL and enables a global 
wildcard whitelist. Those other critical findings hide a regression that 
downgrades the missing-account finding when ACL is enabled.
   
   Add an isolated ACL 2.0 case with no accounts and no other risks. It 
verifies the critical finding, error status and empty summary counts. The 
existing disabled-ACL case now checks that the missing-account finding remains 
a warning there. This is a test-only change.
   
   ### How Did You Test This Change?
   
   - `npm test -- src/utils/aclRiskDiagnostics.test.ts 
src/pages/instance/__tests__/AclPage.test.tsx --maxWorkers=1`: 34 passed.
   - Mutation check: temporarily changed the missing-account severity to always 
be `warning`. The new case failed while the other 7 utility cases passed. 
Restored the production source before final verification.
   - `npm run lint`: no errors; 10 warnings in unchanged files.
   - `npx prettier --check src/utils/aclRiskDiagnostics.test.ts` and `git diff 
--check`: passed.
   - `npm run build`: passed, including the license check (133 components, 140 
license files). Windows `core.autocrlf` initially changed the vendored license 
bytes; the build used their exact committed bytes. No license or production 
file changes are included.
   
   The full frontend suite and Java tests were not run. AI assistance was used; 
the final diff and mutation results were inspected.
   
   ### Checklist
   
   - [x] One coherent change
   - [x] Conventional Commit subject
   - [x] Regression coverage with a discriminating mutation check
   - [x] No new UI text, source files, runtime behavior or architecture changes
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to