RockteMQ-AI commented on issue #11362: URL: https://github.com/apache/rocketmq/issues/11362#issuecomment-6119413801
**Issue Evaluation** Category: `type/bug` | Status: **Confirmed** The reported issue has been verified against the current codebase (develop branch, commit b764205). **Root Cause:** `ProxyAdminAuthInterceptor#resolveSourceIp` reads the raw transport peer address via `Grpc.TRANSPORT_ATTR_REMOTE_ADDR`, bypassing the PROXY protocol client address that `HeaderInterceptor` correctly resolves and stores in `GrpcConstants.REMOTE_ADDRESS`. The data plane authorizes against the resolved address, while the admin surface uses the transport peer — causing ACL mis-evaluation behind proxy-protocol load balancers. **Impact:** Admin ACL silently stops restricting by client IP when the Proxy admin port is behind a PROXY-protocol LB. Audit logs record the LB address instead of the real caller. **Severity:** High — security control bypass in admin plane **Suggested Fix:** `resolveSourceIp()` should reuse the same resolution logic as `HeaderInterceptor`: check for PROXY protocol address first (`AttributeKeys.PROXY_PROTOCOL_ADDR` + `PROXY_PROTOCOL_PORT`), fall back to transport peer address. --- *Automated evaluation by github-manager-bot* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
