RockteMQ-AI commented on issue #11364: URL: https://github.com/apache/rocketmq/issues/11364#issuecomment-6120290237
**Issue Evaluation** Category: `type/bug` | Status: **Confirmed** The reported issue has been verified against the current codebase on `develop` branch (commit `9ea2ccdc2b`). **Root Cause:** The `ProxyAdminGrpcService` implementation of `describeGroupAccumulation` (line ~906) and `listConsumerConnection` (line ~1015) read only `group`/`topics` and `group`/`topic` respectively from the request, but never call `getLiteTopic()`. The `DescribeGroupAccumulationResponse.lite_topic_accumulation` map is never populated by any code path. **Verification:** - `grep` for `getLiteTopic` / `liteTopic` / `lite_topic` in `ProxyAdminGrpcService.java` confirms zero hits in both methods - `AdminModelConverter.java` has no lite-topic handling - The `LITE_TOPIC` case at line 1140 exists in a different context (not in the admin accumulation/connection paths) **Impact:** - `DescribeGroupAccumulation` with `lite_topic` filter returns the whole parent topic's accumulation, which is incorrect for groups consuming multiple lite topics multiplexed onto one physical topic - `ListConsumerConnection` with `liteTopic` filter returns all clients subscribed to the parent topic, not just those subscribed to the specific lite topic - `DescribeGroupAccumulationResponse.lite_topic_accumulation` is always empty **Severity:** Medium — affects correctness of admin observability for lite-topic multiplexing scenarios. **Suggested Fix Direction:** 1. In `describeGroupAccumulation`: when `request.getLiteTopic()` is non-empty, filter the accumulation results to only include offsets for the specified lite topic, and populate `lite_topic_accumulation` in the response 2. In `listConsumerConnection`: when `request.getLiteTopic()` is non-empty, filter the client list to only include clients whose subscription table contains the specific lite topic 3. Alternatively, if lite-topic filtering is not yet supported in the admin surface, respond with an explicit `NOT_SUPPORTED` status (consistent with how `QueryMessage` handles unsupported variants per `docs/proxy-admin.md` §8) An automated fix proposal will be generated. Reply `/approve` to proceed with PR generation, `/revise` to request changes to the approach, or `/reject` to decline. --- *Automated evaluation by github-manager-bot* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
