lizhimins commented on PR #6207:
URL: 
https://github.com/apache/rocketmq-dashboard/pull/6207#issuecomment-6120495878

   Thanks — this is merged, as part of 
[`7df91fde3`](https://github.com/apache/rocketmq-dashboard/commit/7df91fde36241973ee604b763e5edfae5f26c40f)
 on `rocketmq-studio`.
   
   Your change went in together with #6064 and #6303 — all yours, all in the 
same area — so we folded them into a single commit instead of landing several 
near-identical entries for the same subsystem. Nothing was dropped.
   
   The commit message calls this one out explicitly:
   
   > #6207 `closeEntry` at `QueueBrowser.tsx:145-147` only filtered `entries` 
and left `pullingRef` alone, so a same-key pull still in flight passed the 
`requestId === requestSeqRef.current` ownership check at `:128` and re-inserted 
the card the operator had just dismissed (the `catch` branch at `:134` 
re-raised a toast for the same abandoned pull), while `pullingRef.has(key)` at 
`:116` kept that queue locked until the stale request settled → the in-flight 
registry becomes a `Map<string, symbol>` keyed by a per-pull token, all three 
ownership checks go through a single `ownsPull()` helper, and `closeEntry` 
deletes the key's registration and releases the loading lock; the exported 
`pulling` stays a `Set<string>` and the scope-switch and unmount `clear()` 
calls are unaffected.
   
   Closing as folded, not rejected.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to