Loyal-Young opened a new pull request, #6442:
URL: https://github.com/apache/rocketmq-dashboard/pull/6442

   ### Which Issue(s) This PR Fixes
   
   Fixes #6436
   
   ### Brief Description
   
   Compare elapsed time with the configured Duration for pending alerts and 
reminders. A representable Duration can still be too large to add to an 
Instant: `9223372036854775807s` passes the existing parser but previously threw 
during both evaluation paths.
   
   The change avoids constructing the deadline and retains inclusive expiry, 
nanosecond precision, and clock rollback behavior. It complements earlier 
parser overflow handling without changing the accepted rule input.
   
   ### How Did You Test This Change?
   
   - Java 21 `mvn -B -ntp test 
-Dtest=AlertStateMachineTest,AlertRuleDurationTest,NativeAlertProcessorTest`: 
**43 passed**, no failures/errors/skips.
   - The two added extreme-duration cases raised arithmetic overflow before the 
fix; an additional control covers nanosecond expiry and clock rollback for 
pending and firing states.
   - Maven Checkstyle: 0 violations; `git diff --check`: passed.
   
   No live broker/database integration or full Maven suite was run. No 
ArchitectureTest class is present in this snapshot, so no ArchUnit execution is 
claimed.
   
   ### Checklist
   
   - [x] One coherent bug fix; new tests end in `Test`
   - [x] Conventional Commit subject; no new UI strings or source files
   
   ### AI Assistance
   
   AI assistance was used to inspect duration validation and evaluation, draft 
the elapsed-time comparison and regression tests, and execute the listed Java 
checks.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to