Loyal-Young opened a new pull request, #6469:
URL: https://github.com/apache/rocketmq-dashboard/pull/6469

   ### Which Issue(s) This PR Fixes
   
   Fixes #6466
   Refs #5003, #4999
   
   ### Brief Description
   
   Pass the loaded run row's duration into terminal event replay. A persisted 
`run_status` does not contain the duration; the projector previously supplied 
null and serialization omitted `durationMs` from the replayed `run_finished`, 
even when the run row had it.
   
   The overload takes the duration explicitly and retains the existing replay 
method for callers without one. Zero is preserved, and a missing duration stays 
unknown. Live projection and the synthetic terminal path retain their existing 
behavior; no event subtype or wire field is added.
   
   unbridled-41 previously identified this in #4999, which was closed by the 
stale workflow. This fixes the same remaining wire-contract defect with 
regressions covering completed, stopped and failed runs. The current UI does 
not consume this field, so this does not claim to fix a visible UI crash.
   
   ### How Did You Test This Change?
   
   - Three new attach tests inspect the emitted terminal SSE JSON for known 
nonzero and zero durations. All three failed against the original 
implementation.
   - Existing attach tests now explicitly check unknown duration omission and 
the synthetic terminal's recorded duration.
   - `mvn -B -ntp 
-Dtest=AiRunServiceTest,AgentEventProjectorTest,AiEventContractTest test`: 
**233 passed**.
   - Frontend `aiEvents.contract.test.ts`: **16 passed** against the shared 
event fixture.
   - Maven Checkstyle and `git diff --check`: passed.
   
   No live AI provider, database integration, or full application suite was run.
   
   ### Checklist
   
   - [x] One coherent fix with regression tests
   - [x] Existing cross-language event contract retained
   - [x] No new UI strings or dependencies
   
   ### AI Assistance
   
   AI assistance was used to trace persisted and live terminal events, compare 
the earlier report with current code, draft the duration handoff and SSE 
regressions, and execute the listed checks.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to