Loyal-Young opened a new pull request, #6431:
URL: https://github.com/apache/rocketmq-dashboard/pull/6431

   ### Which Issue(s) This PR Fixes
   
   Fixes #6421
   
   ### Brief Description
   
   In mock mode, consumer-group settings updates echoed success but reads 
always returned defaults. Store retry settings with the existing mock group, 
scoped by both name and instance, so reopening the dialog and reading group 
details retain saved values. Returned settings remain detached from mock state. 
Deleting a group removes its settings naturally, and a missing/wrong-instance 
group does not report a successful update.
   
   This affects the demo/mock service only. Real settings requests continue to 
delegate to the API.
   
   ### How Did You Test This Change?
   
   From `web`:
   
   - `node node_modules/vitest/vitest.mjs run 
src/services/consumerService.test.ts --pool=threads --maxWorkers=1`: **25 tests 
passed**. Three added mock regressions failed before the fix; the added 
real-API delegation control passed.
   - Tests cover create/read/update, explicit zero retry limits, same-name 
groups on different instances, detached response objects, missing groups, and 
delete/recreate.
   - ESLint and Prettier on both changed files: passed.
   - `node node_modules/typescript/bin/tsc -p tsconfig.app.json --noEmit 
--pretty false --composite false --incremental false`: passed.
   - `git diff --check`: passed.
   
   No browser end-to-end or live broker test was run.
   
   ### Checklist
   
   - [x] One coherent change; Conventional Commit subject
   - [x] Regression tests added, new names end in `Test`
   - [x] No new UI text, source files, or backend architecture changes
   - [x] Mock behavior now matches the existing settings save/read flow
   
   ### AI Assistance
   
   AI assistance was used to inspect the mock lifecycle, draft the fix and 
regression tests, and execute the local checks above.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to