zmuxuny opened a new pull request, #6376:
URL: https://github.com/apache/rocketmq-dashboard/pull/6376

   ### Which Issue(s) This PR Fixes
   
   Fixes #6358
   
   ### Brief Description
   
   Enter used to confirm a Chinese/Japanese IME candidate currently also runs 
the custom PromQL query. This can replace an investigation result or send an 
incomplete expression before the operator intended to execute it.
   
   Ignore the query-submit shortcut while the native keyboard event is 
composing, including the legacy keyCode 229 path used by some IME/browser 
combinations. Ordinary Enter, Shift+Enter editing, and the Run button keep 
their behavior.
   
   ### How Did You Test This Change?
   
   Base: rocketmq-studio at 779b8c0e7aed2396d3cc72743dcd544ea48e9ae6.
   
   - Both native isComposing and keyCode 229 regressions fail on original 
production; ordinary keyboard/button controls pass.
   - `./node_modules/.bin/vitest run --configLoader runner --no-cache 
src/components/__tests__/MetricsExplorer.test.tsx`: all 42 tests passed, 
including a final rerun after test-title formatting.
   - Tests use the real textarea and assert no custom query API request before 
composition ends, then verify ordinary submission.
   - Full lint: 0 errors / 10 baseline warnings. Changed-file Prettier and diff 
check passed.
   - TypeScript, Vite production build and license check passed (133 components 
/ 140 files). Only test naming changed afterward; the full component suite was 
rerun.
   - Mock APIs only, no live service or credentials. Full frontend 
suite/backend tests were not run locally; CI remains to be verified.
   
   ### Checklist
   
   - [x] One coherent change and Conventional Commit
   - [x] Regression tests added with Test suffix
   - [x] No new UI copy, files, dependencies, or configuration
   - [ ] Backend architecture checks (not run locally; frontend-only change)
   - [x] No documentation change needed for restoring standard IME editing 
behavior
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to