iloveeyjafjalla commented on PR #11382:
URL: https://github.com/apache/rocketmq/pull/11382#issuecomment-6134966237
Thanks for the review. Answering the `force` question: the
`-fr/--forceReplace` parsing is unchanged and still in `executeFromFile` — the
bot's diff view just cut it off. On this branch the method reads:
```java
boolean force = false;
if (commandLine.hasOption("fr") &&
Boolean.parseBoolean(commandLine.getOptionValue("fr").trim())) {
force = true;
}
...
MQAdminUtils.updateTopicConfigMappingAll(wrapper.getBrokerConfigMap(),
defaultMQAdminExt, force);
```
The only change is the last argument: it used to be a literal `false`, so
the parsed flag was discarded in the file mode. A test that asserts the flag
reaches `createStaticTopic` needs the broker request to be captured (the
command creates its own `DefaultMQAdminExt`, and this module has no static
mocking configured), which is out of scope here; the wiring is visible in the
call above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
