RockteMQ-AI commented on issue #11387: URL: https://github.com/apache/rocketmq/issues/11387#issuecomment-6136563110
**Issue Evaluation** Category: `type/bug` | Status: **Confirmed** The reported issue has been verified against the current codebase. **Root Cause:** The `buildMessageProperty` method in `SendMessageActivity.java:245-247` checks `if (userPropertySize > config.getMaxUserPropertySize())` without the `if (max <= 0) return;` guard that all other size limit checks in the same file have (message body, message group, delay time, transaction recovery time). **Impact:** When `maxUserPropertySize` is set to `0` (documented as "no limit"), every message with a tag, key, or user property is rejected with `MESSAGE_PROPERTIES_TOO_LARGE`. The `userPropertySize` calculation includes tag and key bytes, so any non-trivial message fails. **Severity:** Medium — breaks a documented configuration option for the Proxy gRPC v2 producer path. **Code References:** - Bug location: `proxy/src/main/java/org/apache/rocketmq/proxy/grpc/v2/producer/SendMessageActivity.java:245-247` - Documentation: `proxy/src/main/java/org/apache/rocketmq/proxy/config/ProxyConfig.java:151-154` - Working examples: `validateMessageBodySize` (line 140-143), `validateMessageGroup` (line 165-168), `validateDelayTime` (line 179-182) **Proposed Fix:** Add `if (config.getMaxUserPropertySize() <= 0) return;` before the size comparison, consistent with other validators. An automated fix proposal will be generated. Reply `/approve` to proceed with PR generation. --- *Automated evaluation by RockteMQ-AI* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
