pilichoumao opened a new pull request, #6512:
URL: https://github.com/apache/rocketmq-dashboard/pull/6512

   ### Which Issue(s) This PR Fixes
   
   Fixes #6503.
   
   ### Brief Description
   
   A slave-only RW route with eight write queues previously counted as one 
writable broker even though the route had no master address. Address-less queue 
metadata also counted as read/write coverage. Count write coverage only with 
permission, positive queue count and a master address; count read coverage only 
with permission, positive queue count and a broker address.
   
   Keep the reported permissions, queue totals and shares intact. Preserve 
address-backed legacy payloads that omit topology fields, handle blank 
addresses, and add Chinese/English explanations that address coverage does not 
verify network reachability or replace client-specific static/ordered topic 
routing.
   
   ### How Did You Test This Change?
   
   - Regression tests fail on the unchanged baseline and pass after the fix.
   - Route utility + actual TopicPage tests: 58 passed locally and on Linux ECS 
(Node 20.20.2).
   - Frontend lint (0 errors; 10 existing warnings), license tests (5 passed), 
production build and packaged license check passed on ECS.
   - Complete frontend suite: 1611 passed, 2 failed across 159 files. The same 
ProducerPage pointer interaction and UserManagement export failures are 
reproducible on unchanged `779b8c0e` (2 failed, 29 passed in a baseline rerun).
   - No backend or live Broker/NameServer tests; this changes the frontend 
projection of the existing API contract.
   
   ## Related work
   
   Builds on the diagnostics in #2836 and the preferred-master projection from 
#1019/#1025. It corrects coverage counts and the all-topic verdict without 
changing the provider projection. #5566 also touches diagnostic localization; 
this PR adds only the text needed for the corrected coverage semantics.
   
   
   Commands: `npm test -- src/utils/topicRouteDiagnostics.test.ts 
src/pages/instance/__tests__/TopicPage.test.tsx --maxWorkers=1 
--fileParallelism=false`, `npm test -- --maxWorkers=1 --fileParallelism=false`, 
`npm run lint`, `npm run license:test`, `npm run build`.
   
   ### Checklist
   
   - [x] One coherent change
   - [x] Conventional commit subject
   - [x] Regression tests added
   - [x] New UI text has Chinese and English entries
   - [ ] Backend/ArchUnit checks (not run; backend unchanged)
   - [x] Source license headers preserved
   - [x] Behavior documented in API specification and in-app help
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to