RockteMQ-AI commented on issue #11396:
URL: https://github.com/apache/rocketmq/issues/11396#issuecomment-6138640644

   ## Evaluation
   
   **Classification:** type/bug
   **Severity:** Medium — configuration option silently ignored, affects 
high-concurrency broker deployments
   **Status:** ✅ Verified
   
   ### Verification
   
   I verified the issue against the current `develop` branch (commit 
`a7edeecfb`):
   
   1. **`NettyServerConfig.java:38`** — `serverSocketBacklog` field is defined 
with default from `NettySystemConfig.socketBacklog`, and has getter/setter 
(lines 134-139).
   2. **`NettyRemotingServer.java:223`** — the bootstrap hard-codes 
`.option(ChannelOption.SO_BACKLOG, 1024)` instead of using the configured value.
   3. **`getServerSocketBacklog()`** has zero production callers — the only 
reference is the test assertion in `NettyServerConfigTest`.
   
   **Conclusion:** The bug is confirmed. The `serverSocketBacklog` 
configuration is fully wired (field, getter, setter, system property) but the 
value is never read in production code. The accept backlog is always `1024` 
regardless of configuration.
   
   ### Proposed Fix
   
   Change `NettyRemotingServer.java:223`:
   ```java
   // Before
   .option(ChannelOption.SO_BACKLOG, 1024)
   // After
   .option(ChannelOption.SO_BACKLOG, 
this.nettyServerConfig.getServerSocketBacklog())
   ```
   
   I will prepare a PR for this fix shortly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to