yyqdbngt opened a new pull request, #6559:
URL: https://github.com/apache/rocketmq-dashboard/pull/6559

   ### Related
   
   Replaces #4681, which the inactivity workflow closed. GitHub rejected 
reopening the original PR.
   
   ### Change
   
   The data-source connection test resolved a host and checked its addresses 
using a local copy of the save path's SSRF policy. That copy omitted multicast 
and IPv6 unique-local ranges, so a URL that save rejected could still be probed 
through Test connection. Delegate the resolved-address check to 
`UrlHostGuard.areAllowed`, retaining the explicit metadata endpoint exclusions, 
and cover both address classes at the policy and connection-test levels.
   
   The patch applies cleanly to the current `rocketmq-studio` branch.
   
   ### Verification
   
   - `SettingsServiceTest` with JDK 21 and Maven 3.9.11: 46 tests passed, 0 
failures, 0 errors, 0 skipped.
   - `git diff --check`: passed.
   
   The targeted test command was `mvn -f server/pom.xml 
-Dtest=SettingsServiceTest -DfailIfNoTests=false test` with the Maven cache on 
E:.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to