zmuxuny opened a new pull request, #6565:
URL: https://github.com/apache/rocketmq-dashboard/pull/6565

   ### Which Issue(s) This PR Fixes
   
   Fixes #6033. Fixes #6034.
   
   Historical tracking: #4500 and #4505.
   
   Restores #4504 after the inactivity bot closed it on October 13. The 
original PR retains the [human 
review](https://github.com/apache/rocketmq-dashboard/pull/4504#pullrequestreview-5267293419)
 and [response to that 
review](https://github.com/apache/rocketmq-dashboard/pull/4504#issuecomment-5771311228).
 The authenticated author UI does not offer a Reopen control, and the available 
GitHub integration returned HTTP 403 for reopening. This continuation preserves 
the original source branch and commit history. #4507 was already consolidated 
into that work; the rejected mutation proposal #4499 is not included.
   
   ### Revised response policy
   
   A shared, type-safe AliyunResponseValidator validates all nine provider read 
sites and three catalog sites:
   - A present body with an omitted or true success flag is accepted.
   - Explicit false is a 422 business rejection, preserving the provider 
message/code.
   - A missing response/body is a consistent 502 malformed-response error.
   - Empty data in a present accepted body retains existing empty/not-found 
behavior.
   
   This follows the requested nullable-flag compatibility, business-error 
classification, null-body consistency, shared helper, and regression coverage. 
Existing transport exception mapping and mutation/send behavior are unchanged. 
There is no captured live HTTP 200/success=false incident; the evidence uses 
controlled SDK fixtures.
   
   ### Current verification (2026-10-13)
   
   Published head f30294d888f4a5853d45cf5cf27ba47423fe04c7 merges 
rocketmq-studio@779b8c0e7aed2396d3cc72743dcd544ea48e9ae6 without rewriting the 
original history. Its tree was verified identical to the locally tested tree. 
The contribution remains seven backend source/test files.
   
   Java 21.0.12.1, Maven 3.9.11:
   - AliyunResponseValidatorTest, AliyunInstanceProviderTest, 
AliyunCatalogServiceTest, AliyunClientFactoryTest, GlobalExceptionHandlerTest, 
MessageServiceTest, MessageControllerTest, ToolOutputSchemaContractTest: 138 
passed, zero failures/errors/skips.
   - Checkstyle: zero violations; git diff --check passed.
   - mvn -B -ntp -DskipTests package: BUILD SUCCESS, including the 
binary-license gate (278 components). No license-gate bypass.
   - Separate combined snapshot with the refreshed #4514 branch: 224 focused 
tests passed, including two temporary integration assertions that explicit 
business rejection precedes message truncation and an omitted flag permits 
truncated data. These combined-only assertions are not part of this standalone 
patch.
   - Independent code review found no P1/P2 issue. AI assistance was used; the 
diff and tests were reviewed.
   
   Tests used the Mockito Java agent required in this environment. Full MySQL 
integration, frontend, Docker and Go suites were not run locally; GitHub CI 
remains to qualify this exact published head. Historical October 5 packaging 
failures should not be read as current local failures.
   
   ### Coordination
   
   Open #6080 and #6085 handle inventory page completeness and do not replace 
envelope validation. Pairwise merge-tree checks are clean. Both this change and 
the refreshed #4514 tree combine cleanly. The separate Apache queue scan work 
in #5523 is outside scope; its current branch conflicts with current upstream 
in Apache provider/generated catalog files, independent of these cloud changes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to