RockteMQ-AI commented on issue #11400:
URL: https://github.com/apache/rocketmq/issues/11400#issuecomment-6139375255

   **Issue Evaluation**
   
   Category: `type/bug` | Status: **Confirmed**
   
   The reported issue has been verified against the current codebase (commit 
`a7edeec`).
   
   **Root Cause:** `ProxyAdminGrpcService.changeLogLevel()` only calls 
`loggerContext.getLogger(ROOT_LOGGER_NAME).setLevel(...)`, but the shipped 
`rmq.proxy.logback.xml` defines 20 component loggers (e.g. `RocketmqProxy`, 
`RocketmqBroker`, `RocketmqStore`, etc.) each with an explicit `level="INFO"` 
and `additivity="false"`. In Logback, an explicit level prevents inheritance 
from root, so the root-level change has no effect on any component logger.
   
   **Impact:** The `ChangeLogLevel` gRPC API — documented as "dynamically 
change the runtime log level of the server without a restart" — reports success 
but produces no visible change in any component log file. Only unnamed 
third-party loggers routed to root's `broker_default.log` are affected.
   
   **Severity:** medium — the admin API is effectively broken for its intended 
troubleshooting purpose.
   
   **Fix direction:** Iterate `loggerContext.getLoggerList()` and apply the 
requested level to each logger (or at least to all `Rocketmq*` loggers), so the 
runtime change reaches the loggers whose level the configuration pinned.
   
   An automated fix proposal will be generated. Reply `/approve` to proceed 
with PR generation, `/revise` to request changes to the approach, or `/reject` 
to decline.
   
   ---
   *Automated evaluation by github-manager-bot*
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to