pilichoumao opened a new pull request, #6619:
URL: https://github.com/apache/rocketmq-dashboard/pull/6619

   ### Which Issue(s) This PR Fixes
   
   Fixes #6616.
   
   ### Brief Description
   
   The initial cloud-credential load-error test can observe the error alert 
before Ant Design removes its spinner. If that assertion fails before Retry, 
its unused one-time list response survives `clearAllMocks()` and can break the 
following creation test. Both failures occurred in [the frontend job for 
#6611](https://github.com/apache/rocketmq-dashboard/actions/runs/38375952139/job/115224234481),
 whose credential component and tests match the current trunk.
   
   Wait for spinner removal in both error-state tests and reset the list API 
mock before reinstalling each test's default response. Error, stale-row, 
disabled-action and retry assertions remain in place. This only changes the 
existing credential test file.
   
   ### How Did You Test This Change?
   
   - Ubuntu 24.04 ECS, Node.js 20.20.2: all 21 CloudCredentialTab tests passed 
(`vitest run src/pages/settings/__tests__/CloudCredentialTab.test.tsx 
--maxWorkers=1`).
   - Temporary fault injection (not committed): enqueue an unused empty list 
response before the existing render test. Baseline fails waiting for 
`aliyun-test`; the fixed setup passes with the same injection. The original 
spinner race is intermittent and was observed in CI, not deterministically 
reproduced by the isolated ECS run.
   - `npm run lint`: 0 errors, 10 existing warnings. `npm run build`: 
TypeScript project build, Vite production build and license check passed. `npm 
run license:test`: 5 passed. Prettier and diff checks passed.
   - Local full suite: 1603 passed, 1 failed in the unchanged Producer test 
`discards a slow connection response after the topic changes` (dropdown 
pointer-events check); the same case also fails when running that unchanged 
file alone. The 21 credential tests passed in the full run. ECS full-suite 
verification is still running and its result will be added here.
   
   ### Checklist
   
   - [x] One coherent change; unrelated modifications are not bundled in
   - [x] Commit subject follows Conventional Commits
   - [x] Existing tests updated while preserving behavioral assertions
   - [x] No new UI text, source files, production behavior or architecture 
changes
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to