yx9o opened a new pull request, #6620:
URL: https://github.com/apache/rocketmq-dashboard/pull/6620

   ### Brief Description
   
   Legacy 13-field `Pub` trace records omit `offsetMsgId` and store the 
send-success flag at index 12. The parser always read index 13, so successful 
legacy sends appeared as failed in both message-ID and business-key trace 
lookups.
   
   Select the success field according to the producer trace layout supported by 
the RocketMQ SDK. Ignore trailing empty columns when identifying the layout, 
while preserving the existing field positions for newer records with 
`offsetMsgId` or `clientHost`.
   
   Add regressions using the actual SDK decoder as a reference for 13-, 14-, 
and 15-field records, including successful/failed sends, trailing separators, 
empty optional fields, and key filtering.
   
   ### How Did You Test This Change?
   
   - Before the fix, the provider suite ran 78 tests with three expected 
failures: successful legacy message-ID lookup, the same layout with a trailing 
separator, and successful legacy key lookup.
   - `cd server && mvn -B -ntp 
-Dtest=RocketMQMessageProviderTest,MessageServiceTest,MessageControllerTest 
test`: 119 tests passed, with zero failures, errors, or skipped tests; 
compilation and Checkstyle passed.
   - `git diff --check` passed.
   - Independent code review found no actionable issues.
   
   The tests use mocked broker responses and the real RocketMQ trace decoder. 
No live Broker integration was performed.
   
   ### Checklist
   
   - [x] One coherent change; unrelated modifications are not bundled in
   - [x] Commit subject follows Conventional Commits (`fix:`)
   - [x] Tests added for non-trivial changes, test methods named `...Test`
   - [x] New UI text has Chinese and English entries — not applicable; no UI 
text added
   - [ ] Architecture checks — not run in the focused test suite
   - [x] ASF source headers retained; no new source files
   - [x] Compatibility documented in the parser comments; no API schema changes
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to