zmuxuny opened a new pull request, #6734:
URL: https://github.com/apache/rocketmq-dashboard/pull/6734

   ### Which Issue(s) This PR Fixes
   
   Small test-only CI compilation repair; no separate issue.
   
   ### Brief Description
   
   Two email-recipient tests still stub the five-argument claimForDispatch 
signature, while the mapper now requires expectedAttemptCount as a sixth 
argument. Add eq(0) to both stubs: both fixtures explicitly set attemptCount to 
zero. This preserves the existing quoted-display-name and semicolon-recipient 
delivery assertions and does not weaken the retry-count contract with a 
wildcard.
   
   One test file, two lines changed. No production or workflow changes.
   
   This shared trunk compile failure blocks both Java jobs on #6728, although 
its frontend Build, Docker Build, and Go jobs pass:
   - 
https://github.com/apache/rocketmq-dashboard/actions/runs/38726074327/job/116392136059
   - 
https://github.com/apache/rocketmq-dashboard/actions/runs/38726074327/job/116392136065
   
   ### How Did You Test This Change?
   
   Base: `baf70ae6a759570110dce9a1973dc617433492dc`. Head: 
`66d67e9cf9eedee62e15237fea2e5026db80955f`. Java 21 and Maven 3.9.9.
   
   - Unmodified baseline reproduces claimForDispatch arity errors at 
NotificationOutboxServiceTest.java:484 and :516.
   - Checkstyle passes and all 309 test source files compile after the change.
   - Both affected email tests pass (2 tests, zero failures/errors).
   - Mutation: eq(1) instead of eq(0) makes both affected tests fail; restoring 
eq(0) passes again.
   - git diff --check passes.
   - Full 36-test NotificationOutboxServiceTest was attempted: 27 passed; 7 
failures and 2 errors remain in unrelated webhook cases in this sandbox, 
including URL validation rejecting local/loopback-resolved endpoints. This is 
not a full-suite pass claim.
   
   Tests used Mockito's startup Java agent because this sandbox does not 
support dynamic self-attachment; no repository configuration changed. AI 
assistance was used for implementation and validation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to