The GitHub Actions job "CI" on 
rocketmq-dashboard.git/codex/client-summary-connection-count has failed.
Run started by GitHub user iloveeyjafjalla (triggered by iloveeyjafjalla).

Head commit for run:
614870670590be4fef09f34a0272f4ff6e449273 / iloveeyjafjalla <[email protected]>
fix(cluster): count every listed connection in the client summary

The tiles in the connection summary were built from a Map keyed by
`type:clientId`, so they counted de-duplicated clients while the tile label, the
page header and the table footer all count connections. On a real cluster the 
two
disagree as soon as one client serves more than one group - a Java client
registers its own group plus the shared CLIENT_INNER_PRODUCER - and the 
resulting
number is neither the connection count nor the unique-client count, because a
client that is both a producer and a consumer was counted twice.

The tiles now describe the rows the table lists; the de-duplicated view stays in
the diagnostics panel (unique clients / unique addresses).

Verified against a stock Apache RocketMQ 5.3.2 broker (Direct mode, one
nameserver, one broker): the header and the table footer say 7, the tiles report
7 / 6 / 1 / Remoting 7, and mqadmin producerConnection reports the same 6
producer connections.

ClientsPage.test.tsx: 25/25 green; the new case fails on the previous code.

Report URL: 
https://github.com/apache/rocketmq-dashboard/actions/runs/38735916342

With regards,
GitHub Actions via GitBox

Reply via email to