zmuxuny opened a new pull request, #6741:
URL: https://github.com/apache/rocketmq-dashboard/pull/6741

   ### Which Issue(s) This PR Fixes
   
   Fixes #6740.
   
   ### Brief Description
   
   Pass the already-resolved target.Server into the interactive confirmation, 
instead of rereading the configuration. The prompt, automatic preview and 
mutation now share one destination snapshot even if another terminal changes or 
removes the config file. Remove the unused second-read helper. No confirmation 
bypass behavior, API, dependencies or workflows change.
   
   ### How Did You Test This Change?
   
   Base: rocketmq-studio@a92c23144408cdf5729707050e9ecd9b75f1bad0. Published 
head: b6e6fd30b523d6709a034864771aec69ab68471b. Published tree 
43cc9d2dc02f74e5ab115e0335a4844cc891e876 matches the locally tested tree 
exactly. Go 1.27.1, Linux amd64.
   
   - Red before fix: real command test confirmed prompt endpoint B while the 
HTTP request reached endpoint A.
   - Seven regression/control cases pass: unchanged/replaced/removed config, 
explicit-token and automatic-preview flows, plus rejected confirmation sending 
no requests.
   - go test -race -p 1 -count=1 ./... passed across the full Go module.
   - go vet -p 1 ./... passed.
   - make catalog-verify build passed; native binary license checks passed (11 
components, 26 files).
   - gofmt and git diff --check passed.
   - Independent code review and rerun of the seven cases passed.
   
   Tests use temporary config files and httptest endpoints; no live broker 
mutation. Java/frontend suites and six-platform release builds were not run for 
this CLI-only change.
   
   ### Scope and Related Work
   
   #6205 adds runtime unit coverage, whereas this change fixes and tests the 
destination snapshot across the complete command. #6513 concerns competing 
config writes; this defect occurs even when each config write is atomic. AI 
assistance was used for analysis, implementation and regression authoring.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to