The GitHub Actions job "CI" on 
rocketmq-dashboard.git/fix/alerts-never-triggered-sort has failed.
Run started by GitHub user Frun1na (triggered by Frun1na).

Head commit for run:
fa5102ea0b1d6e6cc4aa889b9a49c4b250d3a9c7 / Apulupie 
<[email protected]>
fix(alerts): keep a never-triggered rule out of the first position when sorting 
by trigger time

The alert rules table's "Last Triggered" column sorted a rule that has never 
fired as if it had
fired before every rule that carries a stamp. `lastTriggered` is null for a 
rule that never fired
(the cell renders "从未触发 / Never" for exactly that case), and the sorter 
compared the absent value
as an empty string, which orders before every real timestamp in an ascending 
sort.

The column now uses a comparator that keeps an absent stamp last in both 
directions. Ant Design
negates the comparator for a descending column, so an absent stamp cannot 
simply be treated as the
smallest text; the same rule already applies to an unmeasured TPS on the broker 
cluster page and to
an unset TTL on the Lite topic page.

A rule that never fired is neither the oldest nor the most recent trigger, so 
ascending (find what
fired long ago) and descending (find what fired last) both keep it out of the 
way. No copy changes.

Report URL: 
https://github.com/apache/rocketmq-dashboard/actions/runs/38756870241

With regards,
GitHub Actions via GitBox

Reply via email to