yx9o opened a new pull request, #6765:
URL: https://github.com/apache/rocketmq-dashboard/pull/6765

   ### Brief Description
   
   Fix the bundled Consumer dashboard's "Messages Out TPS by Group" panel. It 
references `$group` without defining that variable and queries the `group` 
label, while RocketMQ native metrics use `consumer_group`.
   
   - Define a consumer group variable from `rocketmq_messages_out_total`, 
scoped to the selected cluster.
   - Use `consumer_group` in the TPS selector, aggregation, and legend.
   - Regenerate the bundled Consumer dashboard and add regression coverage for 
its variables, query, and consistency with the generator.
   
   ### How Did You Test This Change?
   
   - `python3 -m unittest discover -s server/scripts -p 
test_gen_grafana_dashboards.py`: 10 tests passed. The two new regressions 
failed against unchanged production code on the current base.
   - `cd server && mvn -B -ntp 
-Dtest=GrafanaDashboardServiceTest,GrafanaDashboardControllerTest test`: 18 
tests passed, with zero failures, errors, or skipped tests; compilation and 
Checkstyle passed.
   - Regenerated all dashboard assets and confirmed that only 
`rocketmq-consumer.json` changed.
   - `git diff --check` passed.
   - Independent code review found no actionable issues.
   
   No live Grafana import or Prometheus query execution was performed.
   
   ### Checklist
   
   - [x] One coherent change; unrelated modifications are not bundled in
   - [x] Commit subject follows Conventional Commits (`fix:`)
   - [x] Regression tests added using the existing Python unittest conventions
   - [x] Bilingual Studio UI text requirement is not applicable; no Studio UI 
text added
   - [x] Architecture boundaries reviewed; no Java source or dependency changes
   - [x] ASF header requirement for new sources is not applicable; no new 
source files
   - [x] Dashboard assets and their generator updated together
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to