Wang1rrr opened a new pull request, #6973:
URL: https://github.com/apache/rocketmq-dashboard/pull/6973

   ### Which Issue(s) This PR Fixes
   
   Fixes #6969.
   
   ### Brief Description
   
   Quote `REMOTE_PATH` as a literal remote-shell argument in prerequisite 
checks, directory creation, source extraction, image builds, and compose 
startup. Quote the remote Maven bind-mount arguments as well so a working 
directory or home path containing spaces remains one Docker argument.
   
   The shell quoting also preserves apostrophes and dollar signs in a directory 
name. SCP still receives its destination as the existing single argument.
   
   ### How Did You Test This Change?
   
   `python3 -m unittest discover -s deploy -p test_deploy_paths.py`
   
   - Added 3 tests (including web/compose subcases) that execute the actual 
script functions with local SSH and Docker stubs.
   - All four exercised operations fail on the original script with a path 
containing spaces, an apostrophe, and a literal dollar sign.
   - After the fix all tests pass; the server-build case also checks the exact 
Docker bind-mount argument.
   - No remote host, Docker build, or deployment is invoked by these tests. The 
test harness and its cleanup archive use temporary directories.
   
   ### Checklist
   
   - [x] One coherent defect fix with a conventional commit.
   - [x] Regression methods end in `Test`; new test source has the ASF header.
   - [x] No new dependencies or application UI text.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to