Wang1rrr opened a new pull request, #7004:
URL: https://github.com/apache/rocketmq-dashboard/pull/7004

   ## Summary
   
   Fixes #7003.
   
   - Query `node_id` for the shared Broker dropdown.
   - Count native broker IDs and use them for the three native per-broker TPS 
selectors, aggregations and legends.
   - Regenerate the 12 dashboard assets; the shared dropdown accounts for the 
changes across all assets.
   - Add asset/generator checks and a real PromQL evaluation against synthetic 
native series from multiple brokers, topics and clusters.
   
   The variable remains named `$broker`, and other exporter-specific panels 
retain their existing expressions. Consumer-group filtering is handled 
separately by #6765.
   
   ## Validation
   
   - `python3 -m unittest discover -s server/scripts -p 
test_gen_grafana_dashboards.py`: **11 passed** with Prometheus `promtool` 3.5.0 
on PATH. The optional evaluation test invokes `promtool test rules` for four 
expressions; it skips explicitly when promtool is unavailable.
   - Before the fix, PromQL evaluation returned 1 instead of 2 brokers and no 
samples for all three native broker TPS queries. All new checks pass after the 
fix.
   - `mvn -B -ntp 
-Dtest=GrafanaDashboardServiceTest,GrafanaDashboardControllerTest test`: **18 
passed**, Checkstyle passed.
   - Generated assets reviewed; `git diff --check` passed. No live Grafana 
deployment or full backend suite was run locally.
   
   AI-assisted implementation; upstream label definitions, the diff and 
regression output were reviewed before submission.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to