Wang1rrr opened a new pull request, #7009:
URL: https://github.com/apache/rocketmq-dashboard/pull/7009

   ## Summary
   Closes #7008.
   
   Build both Prometheus-compatible request URIs by their components. A small 
shared path helper trims trailing path slashes and appends the backend endpoint 
while preserving escaped path/query data and fragments. The connection probe 
adds its query parameter without encoding existing percent escapes again. 
Existing host validation still runs before the request.
   
   ## Validation
   - Before: 7 of the 8 new regression cases fail (wrong path/query or 
double-encoded path).
   - After: `mvn -B -ntp -Dtest=PrometheusMetricsSourceTest,SettingsServiceTest 
test`: 79 tests pass on Java 21, with Checkstyle passing.
   - The range cases capture the real request target at an embedded HTTP 
server; the probe cases assert the exact URI with MockRestServiceServer. 
Existing backend-specific connectivity cases remain covered.
   - `git diff --check` passes.
   - No live external metrics backend or full backend suite was run locally.
   
   AI assistance was used; the implementation and before/after regression 
results were reviewed.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to